[jira] [Created] (GERONIMO-6658) Issue @Gauge Accept: application/json

Discussion:

Ivan Junckes Filho (JIRA)

2018-11-22 19:55:01 UTC

Ivan Junckes Filho created GERONIMO-6658:
--------------------------------------------

Summary: Issue @Gauge Accept: application/json
Key: GERONIMO-6658
URL: https://issues.apache.org/jira/browse/GERONIMO-6658
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Reporter: Ivan Junckes Filho

Trying access a gauge /metrics/application/<metric-name> with "Accept: application/json" I get the error below:

21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4] org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson and org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson are equal candidates for handling the current request which can lead to unpredictable results
21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4] org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem with writing the data, class java.util.Collections$SingletonMap, ContentType: application/json
21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4] org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor for {[http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints|http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints] has thrown exception, unwinding now
org.apache.cxf.interceptor.Fault
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)
at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.doInvoke(CxfRsHttpListener.java:253)
at org.apache.tomee.webservices.CXFJAXRSFilter.doFilter(CXFJAXRSFilter.java:94)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.openejb.server.httpd.EEFilter.doFilter(EEFilter.java:65)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomee.microprofile.jwt.MPJWTFilter.doFilter(MPJWTFilter.java:64)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.geronimo.microprofile.opentracing.microprofile.server.OpenTracingFilter.doFilter(OpenTracingFilter.java:126)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.tomee.catalina.OpenEJBValve.invoke(OpenEJBValve.java:44)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
at org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:770)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.StackOverflowError

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-22 21:07:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696262#comment-16696262 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441120104

If it helps singleEntry was supposed handling it properly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Ivan Junckes Filho (JIRA)
-------------------------------------
Key: GERONIMO-6658
URL: https://issues.apache.org/jira/browse/GERONIMO-6658
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Ivan Junckes Filho
Priority: Major

21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4] org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson and org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson are equal candidates for handling the current request which can lead to unpredictable results
21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4] org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem with writing the data, class java.util.Collections$SingletonMap, ContentType: application/json
21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4] org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor for {[http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints|http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints] has thrown exception, unwinding now
org.apache.cxf.interceptor.Fault
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)
at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.doInvoke(CxfRsHttpListener.java:253)
at org.apache.tomee.webservices.CXFJAXRSFilter.doFilter(CXFJAXRSFilter.java:94)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.openejb.server.httpd.EEFilter.doFilter(EEFilter.java:65)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomee.microprofile.jwt.MPJWTFilter.doFilter(MPJWTFilter.java:64)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.geronimo.microprofile.opentracing.microprofile.server.OpenTracingFilter.doFilter(OpenTracingFilter.java:126)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.tomee.catalina.OpenEJBValve.invoke(OpenEJBValve.java:44)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
at org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:770)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.StackOverflowError

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Romain Manni-Bucau (JIRA)

2018-11-22 21:12:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696265#comment-16696265 ]

Romain Manni-Bucau commented on GERONIMO-6658:
----------------------------------------------

This is a bug in tomee which shouldnt deploy common module.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-23 18:27:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697418#comment-16697418 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441299764

@rmannibucau it doesn't handle it properly. Gauge needs to go through map() method to get the gauge value. singleEntry prepares it for the prometheus format but doesn't work for json.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-23 21:47:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697528#comment-16697528 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441321577

Point was more the null check can is already done later so a map(this::map) is likely a better fix and would work for other usages and not only this one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-28 20:23:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702353#comment-16702353 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442591418

I am not sure I get your reply @rmannibucau, I added some tests. Can you review them?

Also, if you have an example of this::map would be better, because I didn't get what you mean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-28 20:48:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702373#comment-16702373 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442598808

If you look the code of singleEntry (what you changed) you will see it just misses a map on the metric otherwise it is exactly the same so idea was to fix singleEntry instead of duplicating the code

Side note: please dont add a test module and write the test in common module - not even need a server or endpoint ;).

If still unclear and you are ok i am also fine to just do it tomorrow, it shouldnt be more than 15mn so sure i can do it for you too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-29 00:17:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702553#comment-16702553 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442656310

I will have a look tomorrow, no need to do it for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-29 12:32:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703107#comment-16703107 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442816821

I actually now get it, but adding map there doesn't work:

return ofNullable(metricRegistry.getMetrics().get(name))
.map(metric -> singletonMap(name, map(metric)))
.orElseGet(Collections::emptyMap);

It will change the return type from Metric to Object and won't work for other methods that are using it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-29 12:36:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703110#comment-16703110 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442818000

When you say a server or an endpoint are not necessary, how would you do it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-29 13:06:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703135#comment-16703135 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442826327

Post by ASF GitHub Bot (JIRA)
It will change the return type from Metric to Object and won't work for other methods that are using it.

I'm pretty confident we can make it work, worse case we add a toggle in map method but all endpoints should return the same representation

Post by ASF GitHub Bot (JIRA)
When you say a server or an endpoint are not necessary, how would you do it?

a plain new of the endpoint then you have setters and can call endpoint to check the returned model, no need to go through serialization here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by ASF GitHub Bot (JIRA)
-------------------------------------
Key: GERONIMO-6658
URL: https://issues.apache.org/jira/browse/GERONIMO-6658
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Ivan Junckes Filho
Priority: Major

21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4] org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson and org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson are equal candidates for handling the current request which can lead to unpredictable results
21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4] org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem with writing the data, class java.util.Collections$SingletonMap, ContentType: application/json
21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4] org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor for {[http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints|http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints] has thrown exception, unwinding now
org.apache.cxf.interceptor.Fault
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)
at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.doInvoke(CxfRsHttpListener.java:253)
at org.apache.tomee.webservices.CXFJAXRSFilter.doFilter(CXFJAXRSFilter.java:94)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.openejb.server.httpd.EEFilter.doFilter(EEFilter.java:65)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomee.microprofile.jwt.MPJWTFilter.doFilter(MPJWTFilter.java:64)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.geronimo.microprofile.opentracing.microprofile.server.OpenTracingFilter.doFilter(OpenTracingFilter.java:126)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.tomee.catalina.OpenEJBValve.invoke(OpenEJBValve.java:44)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
at org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:770)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.StackOverflowError

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ASF GitHub Bot (JIRA)

2018-11-29 13:43:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703190#comment-16703190 ]

ASF GitHub Bot commented on GERONIMO-6658:
------------------------------------------

rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442837720

To be concrete, here is the proposal:

diff --git a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
index 4293fd5..405cd45 100644
--- a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
+++ b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
@@ -19,11 +19,13 @@ package org.apache.geronimo.microprofile.metrics.common.jaxrs;
import static java.util.Collections.emptyMap;
import static java.util.Collections.singletonMap;
import static java.util.Optional.ofNullable;
+import static java.util.function.Function.identity;
import static java.util.stream.Collectors.joining;
import static java.util.stream.Collectors.toMap;

import java.util.Collections;
import java.util.Map;
+import java.util.function.Function;
import java.util.stream.Stream;

import javax.ws.rs.GET;
@@ -133,7 +135,7 @@ public class MetricsEndpoints {
@Context final SecurityContext securityContext,
@Context final UriInfo uriInfo) {
securityValidator.checkSecurity(securityContext, uriInfo);
- return singleEntry(name, findRegistry(registry));
+ return singleEntry(name, findRegistry(registry), this::map);
}

@GET
@@ -147,7 +149,7 @@ public class MetricsEndpoints {
final MetricRegistry metricRegistry = findRegistry(registry);
return prometheus.toText(
metricRegistry, registry,
- singleEntry(name, metricRegistry))
+ singleEntry(name, metricRegistry, identity()))
.toString();
}

@@ -175,9 +177,10 @@ public class MetricsEndpoints {
.collect(toMap(Map.Entry::getKey, e -> mapMeta(e.getValue())));
}

- private Map<String, Metric> singleEntry(final String name, final MetricRegistry metricRegistry) {
+ private <T> Map<String, T> singleEntry(final String name, final MetricRegistry metricRegistry,
+ final Function<Metric, T> metricMapper) {
return ofNullable(metricRegistry.getMetrics().get(name))
- .map(metric -> singletonMap(name, metric))
+ .map(metric -> singletonMap(name, metricMapper.apply(metric)))
.orElseGet(Collections::emptyMap);
}

And for the test:

package org.apache.geronimo.microprofile.metrics.common;

import static java.util.Collections.singletonMap;
import static org.junit.Assert.assertEquals;

import javax.ws.rs.core.SecurityContext;
import javax.ws.rs.core.UriInfo;

import org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints;
import org.apache.geronimo.microprofile.metrics.common.jaxrs.SecurityValidator;
import org.apache.geronimo.microprofile.metrics.common.prometheus.PrometheusFormatter;
import org.eclipse.microprofile.metrics.Gauge;
import org.junit.Test;

public class MetricsEndpointTest {
@Test
public void run() {
final RegistryImpl registry = new RegistryImpl();
registry.register("foo", (Gauge<Long>) () -> 1L);

final MetricsEndpoints endpoints = new MetricsEndpoints();
endpoints.setApplicationRegistry(registry);
endpoints.setPrometheus(new PrometheusFormatter());
endpoints.setSecurityValidator(new SecurityValidator() {
@Override
public void checkSecurity(final SecurityContext securityContext, final UriInfo uriInfo) {
// no-op
}
});
final Object json = endpoints.getJson("application", "foo", null, null);
assertEquals(singletonMap("foo", 1L), json);
}
}

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Ivan Junckes Filho

2018-11-30 12:11:37 UTC

Permalink

Hey Romain, I did all your suggestions.

https://github.com/apache/geronimo-metrics/pull/2

Can you review and merge please?

Post by ASF GitHub Bot (JIRA)
[
https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703190#comment-16703190
]
------------------------------------------
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442837720
diff --git
a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
index 4293fd5..405cd45 100644
---
a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
+++
b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/jaxrs/MetricsEndpoints.java
@@ -19,11 +19,13 @@ package
org.apache.geronimo.microprofile.metrics.common.jaxrs;
import static java.util.Collections.emptyMap;
import static java.util.Collections.singletonMap;
import static java.util.Optional.ofNullable;
+import static java.util.function.Function.identity;
import static java.util.stream.Collectors.joining;
import static java.util.stream.Collectors.toMap;
import java.util.Collections;
import java.util.Map;
+import java.util.function.Function;
import java.util.stream.Stream;
import javax.ws.rs.GET;
@@ -133,7 +135,7 @@ public class MetricsEndpoints {
@Context final SecurityContext securityContext,
@Context final UriInfo uriInfo) {
securityValidator.checkSecurity(securityContext, uriInfo);
- return singleEntry(name, findRegistry(registry));
+ return singleEntry(name, findRegistry(registry), this::map);
}
@GET
@@ -147,7 +149,7 @@ public class MetricsEndpoints {
final MetricRegistry metricRegistry =
findRegistry(registry);
return prometheus.toText(
metricRegistry, registry,
- singleEntry(name, metricRegistry))
+ singleEntry(name, metricRegistry, identity()))
.toString();
}
@@ -175,9 +177,10 @@ public class MetricsEndpoints {
.collect(toMap(Map.Entry::getKey, e ->
mapMeta(e.getValue())));
}
- private Map<String, Metric> singleEntry(final String name,
final MetricRegistry metricRegistry) {
+ private <T> Map<String, T> singleEntry(final String name,
final MetricRegistry metricRegistry,
+ final Function<Metric,
T> metricMapper) {
return ofNullable(metricRegistry.getMetrics().get(name))
- .map(metric -> singletonMap(name, metric))
+ .map(metric -> singletonMap(name,
metricMapper.apply(metric)))
.orElseGet(Collections::emptyMap);
}
package org.apache.geronimo.microprofile.metrics.common;
import static java.util.Collections.singletonMap;
import static org.junit.Assert.assertEquals;
import javax.ws.rs.core.SecurityContext;
import javax.ws.rs.core.UriInfo;
import
org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints;
import
org.apache.geronimo.microprofile.metrics.common.jaxrs.SecurityValidator;
import
org.apache.geronimo.microprofile.metrics.common.prometheus.PrometheusFormatter;
import org.eclipse.microprofile.metrics.Gauge;
import org.junit.Test;
public class MetricsEndpointTest {
@Test
public void run() {
final RegistryImpl registry = new RegistryImpl();
registry.register("foo", (Gauge<Long>) () -> 1L);
final MetricsEndpoints endpoints = new MetricsEndpoints();
endpoints.setApplicationRegistry(registry);
endpoints.setPrometheus(new PrometheusFormatter());
endpoints.setSecurityValidator(new SecurityValidator() {
@Override
public void checkSecurity(final SecurityContext
securityContext, final UriInfo uriInfo) {
// no-op
}
});
final Object json = endpoints.getJson("application", "foo", null, null);
assertEquals(singletonMap("foo", 1L), json);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both
org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
and
org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
are equal candidates for handling the current request which can lead to
unpredictable results

Post by Ivan Junckes Filho (JIRA)
21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]

org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem with
application/json

Post by Ivan Junckes Filho (JIRA)
21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]

org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor for
{[
http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints|http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints
<http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints%7Chttp://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints>] has
thrown exception, unwinding now

Post by Ivan Junckes Filho (JIRA)
org.apache.cxf.interceptor.Fault
at

org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)